Cherry-pick #12333 to 7.1: Set client.authentication to required by default.
#12342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set client.authentication to `required` by default. (cherry picked from commit d1446d4)
houndci-bot
reviewed
May 29, 2019
andrewkroh
approved these changes
May 29, 2019
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…red` by default. (elastic#12342) * Set client.authentication to `required` by default. (elastic#12333) * Set client.authentication to `required` by default. (cherry picked from commit 2807784)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #12333 to 7.1 branch. Original message:
When enabling
sslfor a server configuration, ensure that client authentication is required by default.This fix will require client auth by default for tls communication with experimental filebeat
tcpinput and for metricbeat modulehttpmetricsetserver.We do have integration tests for filebeat where I ensured the default setting is tested. For metricbeat I checked manually as I didn't find any related integration tests.
@ph please take care of backporting this to whichever versions it should be applied to.